update posterior predictive sampling and notebook #5268
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
What is the |
This is needed to add a target pointing to the title so we can then reference the notebook with sphinx cross-references. |
Codecov Report
@@ Coverage Diff @@
## main #5268 +/- ##
==========================================
- Coverage 79.17% 79.04% -0.14%
==========================================
Files 88 87 -1
Lines 14346 14334 -12
==========================================
- Hits 11359 11330 -29
- Misses 2987 3004 +17
|
arviz.plot_lm should be used now
Co-authored-by: Michael Osthege <michael.osthege@outlook.com>
| k, | ||
| ) | ||
| warning_vars.append(k) | ||
| warnings.warn( |
There was a problem hiding this comment.
@OriolAbril I think you intended for this warning to only be printed if warnings_vars was not empty. Is this correct? I am currently always getting the output:
/Users/thomas/repo/pymc/pymc/backends/arviz.py:389: UserWarning: The shape of variables in posterior_predictive group is not compatible with number of chains and draws. The automatic dimension naming might not have worked. This can also mean that some draws or even whole chains are not represented.There was a problem hiding this comment.
To be extra clear: The warning prints a space in place of {', '.join(warning_vars)}.
There was a problem hiding this comment.
Yeah, sorry I also missed it in my review.
It needs to be indented into an if warning_vars.
Thanks for reporting this! Do you want to open a PR? Otherwise I'll do it in the morning
notebook was executed on this branch, not on the released beta though
Thank your for opening a PR!
Depending on what your PR does, here are a few things you might want to address in the description: